Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Merge 8.2.x-sync into master #5910

Merged
merged 2 commits into from
Jan 9, 2024
Merged

🤖 Merge 8.2.x-sync into master #5910

merged 2 commits into from
Jan 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2024

Please do a normal merge, not squash merge.
Please fix conflicts if necessary.


Triggered by push

## Simplify and fix runahead computation.

* In back-compat mode the cycle point time zone is assumed to be local, whereas in normal mode it is assumed to be UTC. There was contamination of the point parse caching where the time zone would carry over from tests of back-compat vs normal mode

### Testing
* New runhead integration test.
* Reload: test reloading doesn't nudge the runahead limit
* We were using the pytest-env plugin to run the tests in a non-UTC time zone: The pytest-env plugin doesn't work with pytest-xdist so this was being ignored.
* Add both runahead formats to existing tests for compute runahead. Add compat mode and not compat mode versions of the future triggers bug test.
* Wrote a test to check for changes of runahead limit based on changing task statuses in compat mode.

---------

Co-authored-by: Oliver Sanders <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
Co-authored-by: Tim Pillinger <[email protected]>
@github-actions github-actions bot added the sync PR for synchronising changes between 8.*.x and master label Jan 9, 2024
@wxtim wxtim requested review from oliver-sanders and wxtim January 9, 2024 11:06
@oliver-sanders oliver-sanders merged commit a7cf51b into master Jan 9, 2024
26 of 27 checks passed
@oliver-sanders oliver-sanders deleted the 8.2.x-sync branch January 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync PR for synchronising changes between 8.*.x and master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants